feat(shape): Integrate Shape API with more components #3552

abhiomkar · 2018-09-13T00:35:20Z

This branch integrates shape API to following components:

Menu surface
Notched outline
Select
Text field
FAB
~~Snackbar~~
Top App Bar (Short)
Dialog

Refs #3176

…type

kfranqueiro

Sorry, I had some more comments on this that I apparently never sent.

packages/mdc-menu-surface/README.md

packages/mdc-snackbar/_mixins.scss

kfranqueiro · 2018-09-18T16:28:22Z

packages/mdc-top-app-bar/mdc-top-app-bar.scss

@@ -31,6 +31,7 @@
 .mdc-top-app-bar {
  @include mdc-top-app-bar-fill-color-accessible(primary);
  @include mdc-top-app-bar-icon-ink-color(on-primary);
+  @include mdc-top-app-bar-short-shape-radius(24px);


This style now has an extra class of specificity, which it doesn't really need. (I think changing the mixin's selector is the right call though, based on our intended pattern of applying mixins to a class on the root element.)

It should be possible to embed this within an @at-root block instead, if we also handle the absence of & within the mixin.

See https://github.com/material-components/material-components-web/pull/2238/files for an example.

packages/mdc-textfield/_mixins.scss

kfranqueiro · 2018-09-21T21:00:00Z

Also, we should add dialog to this PR after syncing up from master.

codecov-io · 2018-09-21T22:14:12Z

Codecov Report

Merging #3552 into feat/shape will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           feat/shape    #3552   +/-   ##
===========================================
  Coverage       98.43%   98.43%           
===========================================
  Files             120      120           
  Lines            5192     5192           
  Branches          649      649           
===========================================
  Hits             5111     5111           
  Misses             81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4725fa...30e5c7d. Read the comment docs.

mdc-web-bot · 2018-09-21T22:57:08Z

🤖 Beep boop!

Screenshot test report 🚦

4 screenshots changed from feat/shape on commit b7ca944:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/09/21/22_54_57_187/report/report.html?utm_source=github&utm_content=pr_comment

Details

4 Added:

spec/mdc-dialog/mixins/shape-radius.html

packages/mdc-fab/_variables.scss

mdc-web-bot · 2018-09-21T23:36:31Z

🤖 Beep boop!

Screenshot test report 🚦

4 screenshots changed from feat/shape on commit 30e5c7d:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/09/21/23_34_27_895/report/report.html?utm_source=github&utm_content=pr_comment

Details

4 Added:

spec/mdc-dialog/mixins/shape-radius.html

abhiomkar added 30 commits August 31, 2018 15:57

feat(shape): added shape APIs and updated README.

af1202d

feat(shape): Integrated shape APIs with button & card

e9fea9c

feat(shape): Updated shape API to accept component height instead of …

4f326bc

…type

feat(shape): Removed old shape demos from here

e52d614

Merge branch 'feat/shape' into feat/shape_integrate

114c74e

feat(shape): Added new shape demos here

3967116

feat(shape): Updated shape categories

da8151d

Merge branch 'feat/shape' into feat/shape_integrate

6920554

feat(shape): Updated button & card styles for shapes

1fee295

feat(shape): Updated shape pill resolve functions

4118533

feat(shape): Remove height info from shapes

6c6ccc1

Merge branch 'feat/shape' into feat/shape_integrate

b45e1d9

feat(shape): Update button to use its own height

e6287a1

feat(shape): Updated README and mixins

b8d1c71

Merge branch 'feat/shape_api' into feat/shape_integrate

c47a76a

feat(shape): Use prop-value function when validating radius

30ec24d

Merge branch 'feat/shape' into feat/shape_api

52a11db

feat(shape): water

0159b35

feat(shape): Updated shape demo for drawer

b4aa710

feat(shape): Updated shape demo for card

8d2ab36

feat(shape): Updated drawer mixin for shapes

1b6d580

feat(shape): Simplified shape mixin & functions

b148d1d

Merge branch 'feat/shape_api' into feat/shape_integrate

6fa02d4

feat(shape): Updates to README

ea30a2f

feat(shape): Added docs for functions.scss

a544713

feat(shape): Minor doc updates

eb55fcf

feat(shape): Updates to shape category value

8094aea

Merge branch 'feat/shape_api' into feat/shape_integrate

52036f1

feat(shape): added shape APIs and updated README.

789e631

feat(shape): Updated shape API to accept component height instead of …

645a644

…type

abhiomkar added 3 commits September 17, 2018 14:50

feat(shape): Made prop-value mixin private

b5dc384

Merge branch 'feat/shape_api' into feat/shape_integrate

a78451f

Merge branch 'feat/shape_integrate' into feat/shape_integrate_2

6ddf964

kfranqueiro mentioned this pull request Sep 18, 2018

feat(shape): Integrate Shape API with components #3547

Merged

kfranqueiro reviewed Sep 19, 2018

View reviewed changes

fix(shape): changes for review comments

2cb4710

abhiomkar mentioned this pull request Sep 19, 2018

Integrate shape system API with components #3176

Closed

13 tasks

abhiomkar and others added 6 commits September 20, 2018 14:54

fix(shape): mdc-shape-mask-radius new function & used in image list

839a6aa

feat(shape): Water

96ec234

WIP Add screenshot tests for standard image-list variant

9300ca6

feat(shape): changes for review comments

65b450c

Merge branch 'feat/shape_integrate' into feat/shape_integrate_2

81fa386

feat(shape): Removed mask-top-radius is reused mask-radius instead

6c99e2c

kfranqueiro suggested changes Sep 21, 2018

View reviewed changes

packages/mdc-textfield/_mixins.scss Outdated Show resolved Hide resolved

feat(shape): Text field text area mixin changes

dfe6408

abhiomkar changed the base branch from feat/shape_integrate to feat/shape September 21, 2018 21:58

abhiomkar added 2 commits September 21, 2018 15:02

feat(shape): water

42c6668

Merge branch 'feat/shape' into feat/shape_integrate_2

e65a145

abhiomkar added 2 commits September 21, 2018 15:20

feat(shape): Add shapes to dialog

dbf5a7a

feat(shape): Golden screenshots for dialog

b7ca944

kfranqueiro suggested changes Sep 21, 2018

View reviewed changes

packages/mdc-fab/_variables.scss Show resolved Hide resolved

feat(shape): mini FAB uses height variable

30e5c7d

kfranqueiro approved these changes Sep 24, 2018

View reviewed changes

kfranqueiro mentioned this pull request Sep 24, 2018

Rename corner -> shape in tests #3622

Merged

kfranqueiro merged commit c3063eb into feat/shape Sep 24, 2018

kfranqueiro deleted the feat/shape_integrate_2 branch September 24, 2018 15:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(shape): Integrate Shape API with more components #3552

feat(shape): Integrate Shape API with more components #3552

abhiomkar commented Sep 13, 2018 •

edited

Loading

kfranqueiro left a comment

kfranqueiro Sep 18, 2018

kfranqueiro commented Sep 21, 2018

codecov-io commented Sep 21, 2018 •

edited

Loading

mdc-web-bot commented Sep 21, 2018

4 Added:

mdc-web-bot commented Sep 21, 2018

4 Added:

feat(shape): Integrate Shape API with more components #3552

feat(shape): Integrate Shape API with more components #3552

Conversation

abhiomkar commented Sep 13, 2018 • edited Loading

kfranqueiro left a comment

Choose a reason for hiding this comment

kfranqueiro Sep 18, 2018

Choose a reason for hiding this comment

kfranqueiro commented Sep 21, 2018

codecov-io commented Sep 21, 2018 • edited Loading

Codecov Report

mdc-web-bot commented Sep 21, 2018

Screenshot test report 🚦

4 Added:

mdc-web-bot commented Sep 21, 2018

Screenshot test report 🚦

4 Added:

abhiomkar commented Sep 13, 2018 •

edited

Loading

codecov-io commented Sep 21, 2018 •

edited

Loading